Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 26, 2020

Successful merges:

Failed merges:

r? @ghost

Centril and others added 14 commits March 24, 2020 06:22
Decouple `rustc_hir::print` into `rustc_hir_pretty`

High level summary:
- The HIR pretty printer, `rustc_hir::print` is moved into a new crate `rustc_hir_pretty`.
- `rustc_ast_pretty` and `rustc_errors` are dropped as `rustc_hir` dependencies.
- The dependence on HIR pretty is generally reduced, leaving `rustc_save_analysis`, `rustdoc`, `rustc_metadata`, and `rustc_driver` as the remaining clients.

The main goal here is to reduce `rustc_hir`'s dependencies and its size such that it can start and finish earlier, thereby working towards rust-lang#65031.

r? @Zoxc
Miri nits: comment and var name improvement

r? @eddyb
parser: recover on `...` as a pattern, suggesting `..`

Fixes rust-lang#70388

My first PR to rust. So please let me know if I'm doing something wrong.
simplify match stmt

We actually have a surprising amount of
```rust
match expr {
    $($p:pat)|+ => true,
    _ => false,
}
```
While I would prefer this to be replaced with `matches!`, most cases are
fairly readable anyway so we can just let them be for now.
@Centril
Copy link
Contributor Author

Centril commented Mar 26, 2020

@bors r+ p=4 rollup=never

@bors
Copy link
Collaborator

bors commented Mar 26, 2020

📌 Commit ea42fd7 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 26, 2020
@Centril Centril added the rollup A PR which is a rollup label Mar 26, 2020
@bors
Copy link
Collaborator

bors commented Mar 26, 2020

⌛ Testing commit ea42fd7 with merge 1c1b5a2e4f340e2e1a82910a0ef427f4720e227f...

@bors
Copy link
Collaborator

bors commented Mar 26, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2020
@Centril Centril closed this Mar 26, 2020
@Centril Centril deleted the rollup-ghv6bbg branch March 26, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants